| From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [BUG] Failed Assertion in ReorderBufferChangeMemoryUpdate() |
| Date: | 2021-09-09 13:16:00 |
| Message-ID: | f2dbb309-2152-08a9-c985-474ba60eab53@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 9/9/21 1:16 PM, Amit Kapila wrote:
> On Tue, Sep 7, 2021 at 2:02 PM Drouvot, Bertrand <bdrouvot(at)amazon(dot)com> wrote:
>> On 9/7/21 9:11 AM, Drouvot, Bertrand wrote:
>> Please find enclosed patch v2 (for the master branch) implementing the
>> modified approach of option 2) proposed by Amit.
>>
> The patch looks good to me. I have made a minor modification in the
> comment to make it explicit why we are not subtracting the size
> immediately
Thanks!
Indeed, good point to also mention in the comment why it has been done
that way.
> Kindly prepare back-branch patches and
> test the same.
Please find enclosed the modified (and tested) version for the
REL_13_STABLE branch (the master patch version also applied on
REL_14_STABLE).
Thanks
Bertrand
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-reorder-buffer-memory-accounting-for-toast-ch-13_STABLE.patch | text/plain | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-09-09 13:30:57 | Re: trap instead of error on 32 TiB table |
| Previous Message | kuroda.hayato@fujitsu.com | 2021-09-09 12:36:16 | RE: Allow escape in application_name |