| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: TAP tests and symlinks on Windows |
| Date: | 2020-07-14 07:14:17 |
| Message-ID: | f282d377-c9a0-0ea2-6f15-f311fadf6b3c@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-07-10 13:58, Andrew Dunstan wrote:
> After much frustration and gnashing of teeth here's a patch that allows
> almost all the TAP tests involving symlinks to work as expected on all
> Windows build environments, without requiring an additional Perl module.
> I have tested this on a system that is very similar to that running
> drongo and fairywren, with both msys2 and MSVC builds.
Thanks. This patch works for me in my environment. The code changes
look very clean, so it seems like a good improvement.
Attached is a small fixup patch for some typos and a stray debug message.
A perltidy run might be worthwhile, as Michael already mentioned.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-fixup-win-tap-symlink-2.patch.patch | text/plain | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2020-07-14 07:50:08 | Re: INSERT INTO SELECT, Why Parallelism is not selected? |
| Previous Message | Thomas Munro | 2020-07-14 07:13:13 | Re: Parallel Seq Scan vs kernel read ahead |