Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document

From: "Daniel Verite" <daniel(at)manitou-mail(dot)org>
To: "shihao zhong" <zhong950419(at)gmail(dot)com>
Cc: Jian He <jian(dot)universality(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
Date: 2023-12-01 14:59:22
Message-ID: ef8b3cbb-724c-41b7-9d00-87fe01c8effc@manitou-mail.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

shihao zhong wrote:

> Thanks for your comments, a new version is attached.

In this hunk:

@@ -1097,8 +1097,8 @@ WITH ( MODULUS <replaceable
class="parameter">numeric_literal</replaceable>, REM
method <replaceable>index_method</replaceable>.
The operators are required to be commutative.
Each <replaceable class="parameter">exclude_element</replaceable>
- can optionally specify an operator class and/or ordering options;
- these are described fully under
+ can optionally specify any of the following: a collation, a
+ operator class, or ordering options; these are described fully under
<xref linkend="sql-createindex"/>.
</para>

"a" should be "an" as it's followed by "operator class".

Also the use of "and/or" in the previous version conveys the fact
that operator class and ordering options are not mutually
exclusive. But when using "any of the following" in the new text,
doesn't it loose that meaning?

In case it does, I would suggest the attached diff.

Best regards,
--
Daniel Vérité
https://postgresql.verite.pro/
Twitter: @DanielVerite

Attachment Content-Type Size
update_document_exclude_with_collate_v3-bis.patch text/plain 2.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nurul Karim Rafi 2023-12-01 15:15:17 Re: Materialized view in Postgres from the variables rather than SQL query results
Previous Message Andrew Dunstan 2023-12-01 14:04:19 Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*