Re: PATCH: Make pg_stop_backup() archive wait optional

From: David Steele <david(at)pgmasters(dot)net>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
Date: 2017-03-21 23:26:48
Message-ID: ee92e800-f983-c3a7-ddae-92acae162832@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 3/21/17 2:34 PM, Fujii Masao wrote:
> On Tue, Mar 21, 2017 at 11:03 AM, Tsunakawa, Takayuki
> <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
>> From: David Steele [mailto:david(at)pgmasters(dot)net]
>>> Well, that's embarrassing. When I recreated the function to add defaults
>>> I messed up the AS clause and did not pay attention to the results of the
>>> regression tests, apparently.
>>>
>>> Attached is a new version rebased on 88e66d1. Catalog version bump has
>>> also been omitted.
>>
>> I was late to reply because yesterday was a national holiday in Japan. I marked this as ready for committer. The patch applied cleanly and worked as expected.
>
> The patch basically looks good to me, but one comment is;
> backup.sgml (at least the description for "Making a non-exclusive
> low level backup) seems to need to be updated.

Agreed. Added in the attached patch and rebased on 8027556.

Thanks!
--
-David
david(at)pgmasters(dot)net

Attachment Content-Type Size
pgstopbackup-wait-v5.patch text/plain 6.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-03-21 23:34:17 Aggregates and row types
Previous Message Robert Haas 2017-03-21 23:10:39 Re: increasing the default WAL segment size