Re: [PATCH] pg_stat_toast v0.4

Am 03.01.22 um 17:50 schrieb Justin Pryzby:
> On Mon, Jan 03, 2022 at 05:00:45PM +0100, Gunnar "Nick" Bluth wrote:
>> Am 03.01.22 um 16:52 schrieb Gunnar "Nick" Bluth:
>>
>>> pg_stat_toast_v0.4.patch attached.
>
> Note that the cfbot says this fails under windows

Thanks for the heads up!

>
> http://cfbot.cputube.org/gunnar-quotnickquot-bluth.html
> ...
> [16:47:05.347] Could not determine contrib module type for track_toast
> [16:47:05.347] at src/tools/msvc/mkvcbuild.pl line 31.

Not only Window$... as it turns out, one of the checks was pretty bogus.
Kicked that one and instead wrote two (hopefully) meaningful ones.

Also, I moved the tests to regress/, as they're not really for a module
anyway.

Let's see how this fares!

>> Aaaand I attached a former version of the patch file... sorry, I'm kind of
>> struggling with all the squashing/rebasing...
>
> Soon you will think this is fun :)

As long as you're happy with plain patches like the attached one, I may ;-)

All the best,
--
Gunnar "Nick" Bluth

Eimermacherweg 106
D-48159 Münster

Mobil +49 172 8853339
Email: gunnar(dot)bluth(at)pro-open(dot)de
__________________________________________________________________________
"Ceterum censeo SystemD esse delendam" - Cato