Re: [PATCH] pg_stat_toast v0.4

From: "Gunnar \"Nick\" Bluth" <gunnar(dot)bluth(at)pro-open(dot)de>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Subject: Re: [PATCH] pg_stat_toast v0.4
Date: 2022-01-03 18:01:54
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Am 03.01.22 um 17:50 schrieb Justin Pryzby:
> On Mon, Jan 03, 2022 at 05:00:45PM +0100, Gunnar "Nick" Bluth wrote:
>> Am 03.01.22 um 16:52 schrieb Gunnar "Nick" Bluth:
>>> pg_stat_toast_v0.4.patch attached.
> Note that the cfbot says this fails under windows

Thanks for the heads up!

> ...
> [16:47:05.347] Could not determine contrib module type for track_toast
> [16:47:05.347] at src/tools/msvc/ line 31.

Not only Window$... as it turns out, one of the checks was pretty bogus.
Kicked that one and instead wrote two (hopefully) meaningful ones.

Also, I moved the tests to regress/, as they're not really for a module

Let's see how this fares!

>> Aaaand I attached a former version of the patch file... sorry, I'm kind of
>> struggling with all the squashing/rebasing...
> Soon you will think this is fun :)

As long as you're happy with plain patches like the attached one, I may ;-)

All the best,
Gunnar "Nick" Bluth

Eimermacherweg 106
D-48159 Münster

Mobil +49 172 8853339
Email: gunnar(dot)bluth(at)pro-open(dot)de
"Ceterum censeo SystemD esse delendam" - Cato

Attachment Content-Type Size
pg_stat_toast_v0.5.patch text/x-patch 0 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Blake, Geoff 2022-01-03 18:11:01 Re: Add spin_delay() implementation for Arm in s_lock.h
Previous Message Stephen Frost 2022-01-03 17:36:05 Re: [PoC] Delegating pg_ident to a third party