|From:||Adrien NAYRAT <adrien(dot)nayrat(at)anayrat(dot)info>|
|To:||Andres Freund <andres(at)anarazel(dot)de>|
|Cc:||"Kuroda, Hayato" <kuroda(dot)hayato(at)jp(dot)fujitsu(dot)com>, "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: Log a sample of transactions|
|Views:||Raw Message | Whole Thread | Download mbox|
On 2/15/19 3:24 PM, Adrien NAYRAT wrote:
> On 2/14/19 9:14 PM, Andres Freund wrote:
>> I wonder if this doesn't need a warning, explaining that using this when
>> there are large transactions could lead to slowdowns.
> Yes, I will add some wording
>> It seems pretty weird to have this in postgres.c, given you declared it
>> in xact.h?
> Yes, I have to revise my C. I will move it to
>> Why are both of these checked? ISTM once xact_is_sampled is set, we
>> ought not to respect a different value of log_xact_sample_rate for the
>> rest of that transaction.
> I added theses checks to allow to disable logging during a sampled
> transaction, per suggestion of Masahiko Sawada:
I added a comment to explain why transaction logging is rechecked.
>> As far as I can tell xact_is_sampled is not properly reset in case of
I am not sure if I should disable logging in case of errors. Actually we
postgres=# set log_transaction_sample_rate to 1;
postgres=# set client_min_messages to 'LOG';
LOG: duration: 0.392 ms statement: set client_min_messages to 'LOG';
LOG: duration: 0.345 ms statement: begin;
postgres=# select 1;
LOG: duration: 0.479 ms statement: select 1;
postgres=# select * from missingtable;
ERROR: relation "missingtable" does not exist
LINE 1: select * from missingtable;
postgres=# select 1;
ERROR: current transaction is aborted, commands ignored until end of
LOG: duration: 11390.295 ms statement: rollback;
If I reset xact_is_sampled (after the first error inside
AbortTransaction if I am right), "rollback" statement will not be
logged. I wonder if this "statement" should be logged?
If the answer is no, I will reset xact_is_sampled in AbortTransaction.
Patch attached with fix mentioned above, but without xact_is_sampled reset.
|Next Message||Chapman Flack||2019-03-01 18:23:54||Re: Infinity vs Error for division by zero|
|Previous Message||Robert Haas||2019-03-01 18:15:21||Re: Refactoring the checkpointer's fsync request queue|