| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "ikedamsh(at)oss(dot)nttdata(dot)com" <ikedamsh(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Allow escape in application_name |
| Date: | 2021-12-27 04:39:54 |
| Message-ID: | e7b61420-a97b-8246-77c4-a0d48fba5a45@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/12/27 10:40, kuroda(dot)hayato(at)fujitsu(dot)com wrote:
> Dear Fujii-san, Horiguchi-san,
>
> I confirmed that the feature was committed but reverted the test.
> Now I'm checking buildfarm.
Attached is the patch that adds the regression test for postgres_fdw.application_name. Could you review this?
As Horiguchi-san suggested at [1], I split the test into two, and then tweaked them as follows.
1. Set application_name option of a server option to 'fdw_%d%p'
2. Set postgres_fdw.application_name to 'fdw_%a%u%%'
'fdw_%d%p' and 'fdw_%a%u%%' still may be larger than NAMEDATALEN depending on the regression test environment. To make the test stable even in that case, the patch uses substring() is truncate application_name string in the test query's condition to less than NAMEDATALEN.
[1]
https://postgr.es/m/20211224.184406.814784272581964942.horikyota.ntt@gmail.com
> But anyway I want to say thank you for your contribution!
Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| pgfdw_appname_regression_test_v1.patch | text/plain | 4.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | kuroda.hayato@fujitsu.com | 2021-12-27 06:19:10 | RE: Allow escape in application_name |
| Previous Message | Masahiko Sawada | 2021-12-27 04:23:36 | Re: Skipping logical replication transactions on subscriber side |