Re: error message when subscription target is a partitioned table

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Magnus Hagander <magnus(at)hagander(dot)net>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: error message when subscription target is a partitioned table
Date: 2018-12-04 01:51:40
Message-ID: e769a07a-0eed-b2b1-5ac5-85b417384218@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018/12/03 17:51, Magnus Hagander wrote:
> On Mon, Dec 3, 2018 at 7:39 AM Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
>>> Could we improve the error message that's output when the subscription
>>> target relation is a partitioned table? Currently, we get:
>>>
>>> ERROR: logical replication target relation "public.foo" is not a table
>>>
>>> I think it'd be more helpful to get:
>>>
>>> ERROR: "public.foo" is a partitioned table
>>> DETAIL: Partitioned tables are not supported as logical replication
>> targets
>>>
>>> Thoughts?
>>
>> +1
>
> +1 as well. That is definitely confusing -- to most people, that is still a
> table...

Okay, here is a patch. I didn't find any tests in subscription.sql
related to unsupported relkinds, so didn't bother adding one for this case
either.

Thanks,
Amit

Attachment Content-Type Size
partitioned-table-not-supported-error-logrep.patch text/plain 734 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-12-04 02:23:03 Re: error message when subscription target is a partitioned table
Previous Message Andres Freund 2018-12-04 00:07:40 GIN predicate locking slows down valgrind isolationtests tremendously