From: | Ken Kato <katouknl(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [PATCH] Add min() and max() aggregate functions for xid8 |
Date: | 2022-02-08 04:23:12 |
Message-ID: | e5b3dab3e8dcec6ab7195ca5a57ddd40@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thank you for the comments!
> if (FullTransactionIdFollows(fxid1, fxid2))
> PG_RETURN_FULLTRANSACTIONID(fxid1);
> else
> PG_RETURN_FULLTRANSACTIONID(fxid2);
> Isn't it better to use '0xffffffffffffffff'::xid8 instead of
> '18446744073709551615'::xid8, to more easily understand that this test
> uses maximum number allowed as xid8?
I updated these two parts as you suggested.
> In addition to those two xid8 values, IMO it's better to insert also
> the xid8 value neither minimum nor maximum xid8 ones, for example,
> '42'::xid8.
I added '010'::xid8, '42'::xid8, and '-1'::xid8
in addition to '0'::xid8 and '0xffffffffffffffff'::xid8
just to have more varieties.
Best wishes,
--
Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachment | Content-Type | Size |
---|---|---|
min_max_aggregates_for_xid8_v3.patch | text/x-diff | 6.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | luminate 22 | 2022-02-08 05:12:57 | I would like to participate for postgresql projects |
Previous Message | Julien Rouhaud | 2022-02-08 04:22:10 | Re: shared_preload_libraries = 'pg_stat_statements' failing with installcheck (compute_query_id = auto) |