From: | "Marko Kreen" <markokr(at)gmail(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, "Daniel Blaisdell" <lunk(dot)djedi(at)gmail(dot)com>, "Michael Fuhr" <mike(at)fuhr(dot)org> |
Subject: | Re: pgcrypto: fix memory leak in openssl.c |
Date: | 2006-02-20 15:30:20 |
Message-ID: | e51f66da0602200730y48bc9601m5099015de26947d3@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
On 2/20/06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Marko Kreen" <markokr(at)gmail(dot)com> writes:
> > On 2/18/06, Marko Kreen <markokr(at)gmail(dot)com> wrote:
> >> pgcrypto crypt()/md5 and hmac() leak memory when compiled against
> >> OpenSSL as openssl.c digest ->reset will do two DigestInit calls
> >> against a context. This happened to work with OpenSSL 0.9.6
> >> but not with 0.9.7+.
>
> > Ugh, seems I read the old code slightly wrong. The leak happens
> > also with regular digest(), although it will leak only 1 context
> > instance, not the 1000+ as the crypt-md5 does.
>
> I'm confused --- does this mean that the patch you sent recently
> needs further work?
No, it's fine. As I did not 'fix' old code but replaced it.
It's just that I gave wrong answer to the question 'who is affected?'
--
marko
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2006-02-20 18:45:24 | Re: WIP: further sorting speedup |
Previous Message | Tom Lane | 2006-02-20 15:13:39 | Re: [PATCH] WIP: Create shell-types explicitly |