| From: | bt22kawamotok <bt22kawamotok(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH]Feature improvement for MERGE tab completion |
| Date: | 2022-09-14 05:08:07 |
| Message-ID: | e4993887d2896d5a334d62257fe7f25b@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> When I tried to apply this patch, I got the following warning, please
> fix it.
> Other than that, I think everything is fine.
>
> $ git apply fix_tab_completion_merge_v4.patch
> fix_tab_completion_merge_v4.patch:38: trailing whitespace.
> else if (TailMatches("USING", MatchAny, "ON", MatchAny) ||
> fix_tab_completion_merge_v4.patch:39: indent with spaces.
> TailMatches("USING", MatchAny, "AS", MatchAny, "ON",
> MatchAny) ||
> fix_tab_completion_merge_v4.patch:40: indent with spaces.
> TailMatches("USING", MatchAny, MatchAny, "ON",
> MatchAny))
> fix_tab_completion_merge_v4.patch:53: trailing whitespace.
> else if (TailMatches("WHEN", "MATCHED") ||
> warning: 4 lines add whitespace errors.
Thanks for reviewing.
I fixed the problem and make patch v5.
Please check it.
Regards,
Kotaro Kawamoto
| Attachment | Content-Type | Size |
|---|---|---|
| fix_tab_completion_merge_v5.patch | text/x-diff | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2022-09-14 05:10:32 | RE: why can't a table be part of the same publication as its schema |
| Previous Message | Tom Lane | 2022-09-14 05:02:39 | Re: failing to build preproc.c on solaris with sun studio |