Re: WIP: About CMake v2

From: Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: WIP: About CMake v2
Date: 2016-11-16 03:45:24
Message-ID: e45acb96-4c32-d754-5fb7-d1be31e04fb7@catalyst.net.nz
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Actually, it was not that tricky to separate out the cmake only changes,
and test this on unmodified sources. It appears to work fine for me -
passes 'make check' (needs the v1_1 incremental patch applied of
course). The Patch is attached. I wonder if the original had some
changes for building under latest Windows...(I'm using Ubuntu 16.10,
with cmake 3.5).

regards

Mark

On 16/11/16 16:00, Mark Kirkwood wrote:
> Yeah, there seems to be a lot of these. Looking through them almost
> all concern the addition of piece of code to wrap putenv. e.g:
>
> --- a/src/bin/psql/command.c
> +++ b/src/bin/psql/command.c
> @@ -1350,7 +1350,7 @@ exec_command(const char *cmd,
> char *newval;
>
> newval = psprintf("%s=%s", envvar, envval);
> - putenv(newval);
> + pg_putenv_proxy(newval);
> success = true;
>
> /*
>
> Where pg_putenv_proxy either calls putenv or pgwin32_putenv (the
> latter on windows I'd guess). I wonder if this could have been
> avoided, since the original code handles this sort of thing. There are
> also some minor - and not immediately obvious - changes to a number of
> macros in various includes...If I'm feeling keen I'll experiment to
> see how far I can get without any source changes at all.
>
>
> regards
>
>
> Mark
>
>
> On 09/11/16 08:37, Peter Eisentraut wrote:
>>
>> There are a number of changes in .[ch] and .pl files that are unclear
>> and not explained. Please explain them. You can also submit separate
>> preliminary patches if you need to do some refactoring. Ultimately, I
>> would expect this patch not to require C code changes.
>>
>

Attachment Content-Type Size
cmake_v1_minimal.patch text/x-patch 249.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2016-11-16 04:10:10 Re: Push down more UPDATEs/DELETEs in postgres_fdw
Previous Message Masahiko Sawada 2016-11-16 03:08:01 Re: Quorum commit for multiple synchronous replication.