Re: pgsql: Build all Flex files standalone

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, John Naylor <john(dot)naylor(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Build all Flex files standalone
Date: 2022-09-04 13:34:28
Message-ID: e3f4a3d0-dfcc-41cc-1ed2-acc15700ddef@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 2022-09-04 Su 02:19, John Naylor wrote:
> Crake fails with
>
> headerscheck:
> Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2:
> Sep 04 01:56:01
> /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> fatal error: jsonpath_gram.h: No such file or directory
> Sep 04 01:56:01 26 | #include "jsonpath_gram.h"
> Sep 04 01:56:01 | ^~~~~~~~~~~~~~~~~
> Sep 04 01:56:01 compilation terminated.
> Sep 04 01:56:14 make: *** [GNUmakefile:138: headerscheck] Error 1
> cpluspluscheck:
> Sep 04 01:57:19 In file included from /tmp/cpluspluscheck.HhRV5k/test.cpp:3:
> Sep 04 01:57:19
> /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> fatal error: jsonpath_gram.h: No such file or directory
> Sep 04 01:57:19 26 | #include "jsonpath_gram.h"
> Sep 04 01:57:19 | ^~~~~~~~~~~~~~~~~
>
> I don't get the same in an already-built tree. I also don't see an
> exception for gramparse.h, which I imagine would have the same issue?

Probably happens because crake does vpath builds. I think you're going
to have to set up EXTRAINCLUDES for it - see near the bottom of the
headerscheck script. Possibly something like

    src/backend/utils/adt/*)

    EXTRAINCLUDES="-I $builddir/src/backend/utils/adt" ;;

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-09-04 20:57:43 Re: pgsql: Build all Flex files standalone
Previous Message Amit Kapila 2022-09-04 11:38:55 Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.