>> One other reason the tuplestore should know the position of all the
>> readers is that ideally it would want to be able to discard any tuples
>> older than the oldest read position. That also means it needs to know
>> when all the call sites have allocated their position and don't need
>> to reset it.
> Good point. So we'd need per-position capability flags, not
> I hadn't realized that this would be relevant to window functions.
> Now that I know that, I propose fixing tuplestore for multiple
> positions and committing it separately, before I go back to the CTE
> patch. Then Hitoshi-san will have something he can work with too.
Yes, tuplestore multiple positioning will give the greate help to the
window function. Ideally, it is better that tuplestore'd have all the
positions and have some kind of capability to discard old rows so that
it can stay in TSS_MEM, which helps window function's sliding frame.
But it isn't really critical, just performance matter.
In response to
pgsql-hackers by date
|Next:||From: Csaba Nagy||Date: 2008-10-01 16:07:05|
|Subject: Re: Block-level CRC checks|
|Previous:||From: Tom Lane||Date: 2008-10-01 16:05:06|
|Subject: Re: Block-level CRC checks |