Re: [HACKERS] [PATCH] Incremental sort

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, jtc331(at)gmail(dot)com
Cc: David Steele <david(at)pgmasters(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Darafei Praliaskouski <me(at)komzpa(dot)net>, Antonin Houska <ah(at)cybertec(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCH] Incremental sort
Date: 2018-10-28 18:27:44
Message-ID: dea96b6b-95c5-60e4-ae3a-f4b4c45701c1@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Alexander,

On 06/01/2018 04:22 PM, Alexander Korotkov wrote:
> Hi, James!
>
> On Thu, May 31, 2018 at 11:10 PM James Coleman <jtc331(at)gmail(dot)com
> <mailto:jtc331(at)gmail(dot)com>> wrote:
>
> I've attached an updated copy of the patch that applies cleanly to
> current master.
>
>
> Thank you for rebasing this patch. Next time sending a patch,
> please make sure you've bumped its version, if even you made no
> changes there besides to pure rebase. Otherwise, it would be hard to
> distinguish patch versions, because patch files have exactly same
> names.
>
> I'd like to note, that I'm going to provide revised version of this
> patch to the next commitfest. After some conversations at PGCon
> regarding this patch, I got more confident that providing separate
> paths for incremental sorts is right. In the next revision of this
> patch, incremental sort paths would be provided in more cases.
>

Do you plan to submit an updated patch version for the November CF? It
would be good to look at the costing model soon, otherwise it might end
up missing PG12, and that would be unfortunate.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2018-10-28 18:42:27 Re: Conflicting option checking in pg_restore
Previous Message Tomas Vondra 2018-10-28 18:20:35 Re: FETCH FIRST clause WITH TIES option