| From: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Allow pg_archivecleanup to remove backup history files |
| Date: | 2023-05-22 09:24:49 |
| Message-ID: | dea86e6f7224b41266b8a2bded766ca1@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-05-15 15:22, Michael Paquier wrote:
> On Mon, May 15, 2023 at 03:16:46PM +0900, torikoshia wrote:
>> On 2023-05-15 09:18, Michael Paquier wrote:
>>> How about plugging in some long options, and use something more
>>> explicit like --clean-backup-history?
>>
>> Agreed.
>
> If you begin to implement that, it seems to me that this should be
> shaped with a first separate patch that refactors the code to use
> getopt_long(), and a second patch for the proposed feature that builds
> on top of it.
Thanks for your advice, attached patches.
--
Regards,
--
Atsushi Torikoshi
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Introduce-pg_archivecleanup-into-getopt_long.patch | text/x-diff | 4.0 KB |
| v3-0002-Allow-pg_archivecleanup-to-remove-backup-history-.patch | text/x-diff | 10.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2023-05-22 09:40:23 | Re: ResourceOwner refactoring |
| Previous Message | Pavel Stehule | 2023-05-22 09:24:21 | Re: Adding SHOW CREATE TABLE |