| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improvements and additions to COPY progress reporting |
| Date: | 2021-02-15 16:07:11 |
| Message-ID: | de9df4db-a8e8-ec5f-9540-c5834ab76345@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I agree with these changes in general - I have a couple minor comment:
1) 0001
- the SGML docs are missing a couple tags
- The blocks in copyfrom.cc/copyto.c should be reworked - I don't think
we do this in our codebase. Move the variable declarations to the
beginning, get rid of the out block. Or something like that.
- I fir the "io_target" name misleading, because in some cases it's
actually the *source*.
2) 0002
- I believe "each backend ... reports its" (not theirs), right?
- This seems more like a generic docs improvement, not quite specific to
the COPY progress patch. It's a bit buried, maybe it should be posted
separately. OTOH it's pretty small.
3) 0003
- Some whitespace noise, triggering "git am" warnings.
- Might be good to briefly explain what the regression test does with
the triggers, etc.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Add-progress-reported-components-for-COPY-progress-r.patch | text/x-patch | 10.4 KB |
| v7-0002-0001-review.patch | text/x-patch | 1.9 KB |
| v7-0003-Add-backlinks-to-progress-reporting-documentation.patch | text/x-patch | 7.4 KB |
| v7-0004-0002-review.patch | text/x-patch | 4.1 KB |
| v7-0005-Add-copy-progress-reporting-regression-tests.patch | text/x-patch | 4.7 KB |
| v7-0006-0003-review.patch | text/x-patch | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-02-15 16:32:43 | Re: POC: postgres_fdw insert batching |
| Previous Message | Laurenz Albe | 2021-02-15 16:06:52 | Re: A reloption for partitioned tables - parallel_workers |