| From: | David Zhang <david(dot)zhang(at)highgo(dot)ca> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Daniel Verite <daniel(at)manitou-mail(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Making psql error out on output failures |
| Date: | 2020-02-29 05:23:49 |
| Message-ID: | dc985d99-4ad5-08de-4da6-136e17439ae3@highgo.ca |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Alvaro,
Thanks for your review, now the new patch with the error message in PG
style is attached.
On 2020-02-28 8:03 a.m., Alvaro Herrera wrote:
> On 2020-Feb-18, David Zhang wrote:
>
>> 3. I think a better way to resolve this issue will still be the solution
>> with an extra %m, which can make the error message much more informative to
>> the end users.
> Yes, agreed. However, we use a style like this:
>
> pg_log_error("could not print tuples: %m");
>
--
David
Software Engineer
Highgo Software Inc. (Canada)
www.highgo.ca
| Attachment | Content-Type | Size |
|---|---|---|
| Fix-psql-to-report-IO-errors-on-writing-query-results_27-2400-msg-in-PG-style.patch | text/plain | 961 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-02-29 05:24:59 | Catalog invalidations vs catalog scans vs ScanPgRelation() |
| Previous Message | Dilip Kumar | 2020-02-29 05:07:44 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |