| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Subject: | Re: SQL/JSON: JSON_TABLE |
| Date: | 2021-03-26 20:28:58 |
| Message-ID: | dacf209e-b098-41bf-2d1c-4cf6e64ad511@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/25/21 8:10 AM, David Steele wrote:
> On 1/20/21 8:42 PM, Nikita Glukhov wrote:
>> Thank you for review.
>>
>> Attached 45th version of the patches. "SQL/JSON functions" patch
>> corresponds to
>> v52 patch set posted in the separate thread.
>
> Another rebase needed (http://cfbot.cputube.org/patch_32_2902.log),
> marked Waiting on Author.
>
> I can see that Álvaro suggested that the patch be split up so it can
> be reviewed and committed in pieces. It looks like you've done that to
> some extent, but I wonder if more can be done. In particular, it looks
> like that first patch could be broken up -- at lot.
>
>
I've rebased this. Note that the large first patch is just the
accumulated patches from the 'SQL/JSON functions' thread, and should be
reviewed there. Only patches 2 thru 4 should be reviewed here. In fact
there are no changes at all in those patches from the previous set other
than a little patch fuzz. The only substantial changes are in patch 1,
which had bitrotted. However, I'm posting a new series to keep the
numbering in sync.
If the cfbot is happy I will set back to 'Needs review'
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-SQL-JSON-functions-v46.patch.gz | application/gzip | 72.9 KB |
| 0002-JSON_TABLE-v46.patch.gz | application/gzip | 18.7 KB |
| 0003-JSON_TABLE-PLAN-DEFAULT-clause-v46.patch.gz | application/gzip | 5.9 KB |
| 0004-JSON_TABLE-PLAN-clause-v46.patch.gz | application/gzip | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erik Rijkers | 2021-03-26 20:48:00 | Re: SQL/JSON: JSON_TABLE |
| Previous Message | Thomas Munro | 2021-03-26 20:26:40 | Re: MultiXact\SLRU buffers configuration |