On 14.07.23 10:56, Peter Eisentraut wrote:
> On 14.07.23 09:54, Peter Eisentraut wrote:
>>>> diff --git a/src/tools/pginclude/cpluspluscheck
>>>> b/src/tools/pginclude/cpluspluscheck
>>>> index 4e09c4686b..287395887c 100755
>>>> --- a/src/tools/pginclude/cpluspluscheck
>>>> +++ b/src/tools/pginclude/cpluspluscheck
>>>> @@ -134,6 +134,9 @@ do
>>>> test "$f" = src/interfaces/ecpg/preproc/preproc.h && continue
>>>> test "$f" = src/test/isolation/specparse.h && continue
>>>>
>>>> + # FIXME
>>>> + test "$f" = src/backend/utils/adt/jsonpath_internal.h && continue
>>>> +
>>>> # ppport.h is not under our control, so we can't make it
>>>> standalone.
>>>> test "$f" = src/pl/plperl/ppport.h && continue
>>>
>>> Hm, what's that about?
>>
>> Don't remember ... ;-) I removed this.
>
> Ah, there was a reason. The headerscheck and cpluspluscheck targets
> need jsonpath_gram.h to be built first. Which previously happened
> indirectly somehow? I have fixed this in the new patch version. I also
> fixed the issue that Álvaro reported nearby.
Apparently, the headerscheck and cpluspluscheck targets still didn't
work right in the Cirrus jobs. Here is an updated patch to address
that. This is also rebased over some recent changes that affected this
patch (generated wait events stuff).