From: | Nicolai Tufar <ntufar(at)gmail(dot)com> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org> |
Subject: | Re: [pgsql-hackers-win32] snprintf causes regression tests |
Date: | 2005-03-10 22:43:48 |
Message-ID: | d8092939050310144364c45103@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-hackers-win32 pgsql-patches |
On Thu, 10 Mar 2005 16:26:47 -0500 (EST), Bruce Momjian
<pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> Please see my posting about using a macro for snprintf. If the current
> implementation of snprintf is enough for our existing translation users
> we probably don't need to add anything more to it because snprintf will
> not be exported to client applications.
Oh, Bruce. It will be the best solution. I was worried about
the problems with my modifications to snprintf.c Tom Lane
pointed out. But if we really separate snprintf() used by
messages and snprintf() used by the like of
src/backend/utils/adt/int8.c then we are safe. We can claim
current release safe and I will modify src/port/snprintf.c at my
leisure later. I will try out your modifications tomorrow. It
is late here and I have a PostgreSQL class to to teach
tomorrow ;)
I still think that it is more convenient to rip off current
implementation of snprintf.c and replace it with a very much
stripped down of Trio's one. I will work on it and try to get
a patch in one week's time. Thank you all for your patience.
Best regards,
Nicolai Tufar
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
> + If your life is a hard drive, | 13 Roberts Road
> + Christ can be your backup. | Newtown Square, Pennsylvania 19073
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-03-10 23:09:30 | Re: [HACKERS] We are not following the spec for HAVING without GROUP BY |
Previous Message | Mark Shewmaker | 2005-03-10 22:42:07 | Re: [HACKERS] We are not following the spec for HAVING without GROUP BY |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-03-10 23:55:06 | Re: [pgsql-hackers-win32] snprintf causes regression tests to fail |
Previous Message | Bruce Momjian | 2005-03-10 21:26:47 | Re: [pgsql-hackers-win32] snprintf causes regression tests |
From | Date | Subject | |
---|---|---|---|
Next Message | Mark Kirkwood | 2005-03-10 23:29:34 | Re: Display Pg buffer cache (WIP) |
Previous Message | Bruce Momjian | 2005-03-10 21:26:47 | Re: [pgsql-hackers-win32] snprintf causes regression tests |