Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Date: 2018-03-03 14:52:40
Message-ID: d807dc44-55f9-5c23-97e5-a5881f4135e2@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 03/03/2018 06:19 AM, Erik Rijkers wrote:
> On 2018-03-03 01:55, Tomas Vondra wrote:
>> Hi there,
>>
>> attached is an updated patch fixing all the reported issues (a bit more
>> about those below).
>
> Hi,
>
> 0007-Track-statistics-for-streaming-spilling.patch  won't apply.  All
> the other patches apply ok.
>
> patch complaints with:
>
> patching file doc/src/sgml/monitoring.sgml
> patching file src/backend/catalog/system_views.sql
> Hunk #1 succeeded at 734 (offset 2 lines).
> patching file src/backend/replication/logical/reorderbuffer.c
> patching file src/backend/replication/walsender.c
> patching file src/include/catalog/pg_proc.h
> Hunk #1 FAILED at 2903.
> 1 out of 1 hunk FAILED -- saving rejects to file
> src/include/catalog/pg_proc.h.rej
> patching file src/include/replication/reorderbuffer.h
> patching file src/include/replication/walsender_private.h
> patching file src/test/regress/expected/rules.out
> Hunk #1 succeeded at 1861 (offset 2 lines).
>
> Attached the produced reject file.
>

Yeah, that's due to fd1a421fe66 which changed columns in pg_proc.h.
Attached is a rebased patch, fixing this.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Introduce-logical_work_mem-to-limit-ReorderBuffer.patch.gz application/gzip 9.9 KB
0002-Immediatel-WAL-log-assignments.patch.gz application/gzip 6.7 KB
0003-Issue-individual-invalidations-with-wal_level-logica.patch.gz application/gzip 4.8 KB
0004-Extend-the-output-plugin-API-with-stream-methods.patch.gz application/gzip 5.3 KB
0005-Implement-streaming-mode-in-ReorderBuffer.patch.gz application/gzip 10.8 KB
0006-Add-support-for-streaming-to-built-in-replication.patch.gz application/gzip 19.6 KB
0007-Track-statistics-for-streaming-spilling.patch.gz application/gzip 4.3 KB
0008-BUGFIX-make-sure-subxact-is-marked-as-is_known_as_su.patch.gz application/gzip 570 bytes
0009-BUGFIX-set-final_lsn-for-subxacts-before-cleanup.patch.gz application/gzip 626 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2018-03-03 14:53:57 Re: All Taxi Services need Index Clustered Heap Append
Previous Message Peter Eisentraut 2018-03-03 14:46:11 Re: TAP test module - PostgresClient