| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
|---|---|
| To: | Salma Elsayed <salmasayed182003(at)gmail(dot)com> |
| Cc: | Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, "Koshi Shibagaki (Fujitsu)" <shibagaki(dot)koshi(at)fujitsu(dot)com> |
| Subject: | Re: CREATE TABLE .. LIKE copies comments to an unrelated table |
| Date: | 2026-10-29 19:15:52 |
| Message-ID: | d6be61f8-5abc-41db-ad20-9785f4530634@uni-muenster.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29/10/2026 16:58, Salma Elsayed wrote:
> The test covers the column comment case. Would it be worth also
> covering the constraint case from the commit message?
Done.
v2 adds the missing tests.
Thanks for the review. Much appreciated!
Best, Jim
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-copied-comments-landing-on-wrong-table-in-CRE.patch | text/x-patch | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yash Jadhav | 2026-10-29 19:23:20 | Re: Proposal: Include CHECK constraint expression in violation error DETAIL |
| Previous Message | Nikolay Samokhvalov | 2026-10-29 19:03:52 | Re: Python/pytest test framework take two |