| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Transaction control in procedures |
| Date: | 2018-01-16 15:16:15 |
| Message-ID: | d60560be-f6a6-ba8b-2ee2-7a7bc7d4666b@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/15/18 12:57, Andrew Dunstan wrote:
> This confused me slightly:
>
> + Transactions cannot be ended inside loops through query results
> or inside
> + blocks with exception handlers.
>
> I suggest: "A transaction cannot be ended inside a loop over query
> results, nor inside a block with exception handlers."
fixed
> The patch has bitrotted slightly in src/backend/commands/portalcmds.c
merged
> The plperl expected file needs updating. Also, why does spi_commit() in
> a loop result in an error message but not spi_rollback()?
This is all changed now after the patch for portal pinning in PL/Perl
and PL/Python has been committed. The attached patch behaves better.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Transaction-control-in-PL-procedures.patch | text/plain | 91.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adam Brightwell | 2018-01-16 15:54:36 | Re: PATCH: Exclude unlogged tables from base backups |
| Previous Message | Alvaro Herrera | 2018-01-16 14:58:39 | Re: [HACKERS] Proposal: Local indexes for partitioned table |