Re: Reject access to unlogged tables in contrib modules

On 06/11/2026 06:26, Michael Paquier wrote:
> Note that for pg_visibility, read_stream has some protections when it
> comes to temp tables of other sessions, but that does not fly under
> !include_pd. Merged 0004 and 0005 together, tweaked a bit the whole,
> and applied.
>
> pgrowlocks (uses read_stream, safe for temp from other settions,
> complains about recovery) has a single point of failure, with a weird
> error message. Done as well.

Thanks!

> Regarding pg_freespacemap, I am not convinced. Returning 0 reflects
> also the reality: there is no FSM for the temp-from-other-session case
> and temp/unlogged at recovery.

Fair enough.

> For pageinspect, we have a pageinspect.h, where I'd suggest to have a
> common routine for the whole to remove the duplication. For
> pgstattuple, we don't have a "common" path, but that seems worth
> having to avoid duplicating this kind of check all over the place.

PFA v5.

0001 (pageinspect) and 0002 (pgstattuple) add the helper function
check_relation_accessible(), where the tests for unlogged and temporary
tables now live. While at it, I moved the existing
RELATION_IS_OTHER_TEMP(rel) check to the same function, so that all
checks are kept in one place.

Best, Jim