Fix database creation during installchecks for ICU cluster

From: Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Fix database creation during installchecks for ICU cluster
Date: 2022-10-29 09:54:43
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


This is a copy of [1] moved to a separated thread for Commitfest..

I discovered an interesting behaviour during installcheck runs on PG 15+
when the cluster was initialized with ICU locale provider:

$ initdb --locale-provider icu --icu-locale en-US -D data &&
pg_ctl -D data -l logfile start

1) The ECPG tests fail because they use the SQL_ASCII encoding [2], the
database template0 uses the ICU locale provider and SQL_ASCII is not
supported by ICU:

$ make -C src/interfaces/ecpg/ installcheck
============== creating database "ecpg1_regression" ==============
ERROR: encoding "SQL_ASCII" is not supported with ICU provider
ERROR: database "ecpg1_regression" does not exist
command failed: "/home/marina/postgresql/master/my/inst/bin/psql" -X -c
"CREATE DATABASE \"ecpg1_regression\" TEMPLATE=template0
ENCODING='SQL_ASCII'" -c "ALTER DATABASE \"ecpg1_regression\" SET
lc_messages TO 'C';ALTER DATABASE \"ecpg1_regression\" SET lc_monetary
TO 'C';ALTER DATABASE \"ecpg1_regression\" SET lc_numeric TO 'C';ALTER
DATABASE \"ecpg1_regression\" SET lc_time TO 'C';ALTER DATABASE
\"ecpg1_regression\" SET bytea_output TO 'hex';ALTER DATABASE
\"ecpg1_regression\" SET timezone_abbreviations TO 'Default';"

2) The option --no-locale in pg_regress is described as "use C locale"
[3]. But in this case the created databases actually use the ICU locale
provider with the ICU cluster locale from template0 (see

$ make NO_LOCALE=1 installcheck

In regression.diffs:

diff -U3
2022-09-27 05:31:27.674628815 +0300
2022-10-21 15:09:31.232992885 +0300
@@ -143,6 +143,798 @@
\set filename :abs_srcdir '/data/'
COPY person FROM :'filename';
+NOTICE: varstrfastcmp_locale sss->collate_c 0 sss->locale 0xefacd0
+NOTICE: varstrfastcmp_locale sss->locale->provider i
+NOTICE: varstrfastcmp_locale sss->locale-> en-US

The patch
v1-0001-Fix-database-creation-during-installchecks-for-IC.patch fixes
both issues for me.


Marina Polyakova
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
diff_check_backend_used_provider.txt text/x-diff 9.7 KB
v1-0001-Fix-database-creation-during-installchecks-for-IC.patch text/x-diff 2.3 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message 2022-10-29 10:57:17 回复: access method xxx does not exist
Previous Message Alvaro Herrera 2022-10-29 09:30:42 Re: Support logical replication of DDLs