| From: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | andres(at)anarazel(dot)de, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org, rjuju123(at)gmail(dot)com, Bruce Momjian <bruce(at)momjian(dot)us>, postgres(at)jeltef(dot)nl |
| Subject: | Re: RFC: Allow EXPLAIN to Output Page Fault Information |
| Date: | 2025-10-28 08:43:49 |
| Message-ID: | d3c9f4b3544d483693058067fa0adf2c@oss.nttdata.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-05-08 22:51, torikoshia wrote:
> On 2025-04-11 22:18, torikoshia wrote:
>> On 2025-03-25 10:27, torikoshia wrote:
>>> On 2025-03-22 20:23, Jelte Fennema-Nio wrote:
>>>
>>>> On Wed, 19 Mar 2025 at 14:15, torikoshia
>>>> <torikoshia(at)oss(dot)nttdata(dot)com> wrote:
>>>>> BTW based on your discussion, I thought this patch could not be
>>>>> merged
>>>>> anytime soon. Does that align with your understanding?
>>>>
>>>> Yeah, that aligns with my understanding. I don't think it's
>>>> realistic
>>>> to get this merged before the code freeze, but I think both of the
>>>> below issues could be resolved.
>>>>
>>>>> - With bgworker-based AIO, this patch could mislead users into
>>>>> underestimating the actual storage I/O load, which is undesirable.
>>>>
>>>> To resolve this, I think the patch would need to change to not
>>>> report
>>>> anything if bgworker-based AIO is used.
>>>
>>> Agreed.
>>> I feel the new GUC io_method can be used to determine whether
>>> bgworker-based AIO is being used.
>>
>> I took this approach and when io_method=worker, no additional output
>> is shown in the attached patch.
>
Rebased the patch again.
--
Regards,
--
Atsushi Torikoshi
Seconded from NTT DATA Japan Corporation to SRA OSS K.K.
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Add-storage-I-O-tracking-to-BUFFERS-option.patch | text/x-diff | 71.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Quan Zongliang | 2025-10-28 08:53:29 | Re: Consistently use the XLogRecPtrIsInvalid() macro |
| Previous Message | Tatsuo Ishii | 2025-10-28 08:36:13 | Re: C11: should we use char32_t for unicode code points? |