Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors

From: Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Date: 2018-09-11 13:55:23
Message-ID: d318cdee8f96de6b1caf2ce684ffe4db@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11-09-2018 16:47, Marina Polyakova wrote:
> On 08-09-2018 16:03, Fabien COELHO wrote:
>> Hello Marina,
>> I'd insist in a comment that "cnt" does not include "skipped"
>> transactions
>> (anymore).
>
> If you mean CState.cnt I'm not sure if this is practically useful
> because the code uses only the sum of all client transactions
> including skipped and failed... Maybe we can rename this field to
> nxacts or total_cnt?

Sorry, I misread your proposal for the first time. Ok!

--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-09-11 14:25:35 Re: StandbyAcquireAccessExclusiveLock doesn't necessarily
Previous Message Marina Polyakova 2018-09-11 13:47:57 Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors