Re: PATCH: Exclude additional directories in pg_basebackup

From: David Steele <david(at)pgmasters(dot)net>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
Subject: Re: PATCH: Exclude additional directories in pg_basebackup
Date: 2016-09-27 14:27:22
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 9/26/16 2:36 AM, Michael Paquier wrote:

> Just a nit:
> <para>
> - <filename></>
> + <filename></> and <filename>postmaster.opts</>
> </para>
> Having one <para> block for each file would be better.

OK, changed.

> +const char *excludeFile[] =
> excludeFiles[]?
> +# Move pg_replslot out of $pgdata and create a symlink to it
> +rename("$pgdata/pg_replslot", "$tempdir/pg_replslot")
> + or die "unable to move $pgdata/pg_replslot";
> +symlink("$tempdir/pg_replslot", "$pgdata/pg_replslot");
> This will blow up on Windows. Those tests need to be included in the
> SKIP block. Even if your code needs to support junction points on
> Windows, as perl does not offer an equivalent for it we just cannot
> test it on this platform.



Attachment Content-Type Size
basebackup-exclusions-v5.patch text/plain 20.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-09-27 14:31:53 Re:
Previous Message Stephen Frost 2016-09-27 14:26:46 Re: Showing parallel status in \df+