| From: | David Steele <david(at)pgbackrest(dot)org> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, solai v <solai(dot)cdac(at)gmail(dot)com> |
| Subject: | Re: Return pg_control from pg_backup_stop(). |
| Date: | 2026-10-23 12:42:13 |
| Message-ID: | d1697de1-eb7f-41bf-a4b7-bba7203df11f@pgbackrest.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/21/26 15:07, David Steele wrote:
> Patch has been rebased.
A committer pointed out to me that part of this patch fixes a bug and
could be back-patched, so it should be separate.
Patch 01 now fixes only the possibility of a torn pg_control file. It
makes the copy out of memory to reduce the time the lock is held, but it
could alternately read the pg_control file in the lock as was done by
Thomas in c558e6fd92f. If the consensus is that the latter approach is
preferred I'm happy to make that change.
Patch 02 implements the flag to enforce the presence of backup_label and
credits Andres with the original idea. This is the bulk of the prior patch.
Regards,
-David
| Attachment | Content-Type | Size |
|---|---|---|
| pgcontrol-v16-01-fix-tear.patch | text/plain | 5.2 KB |
| pgcontrol-v16-02-backuplabel-flag.patch | text/plain | 23.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2026-10-23 12:42:50 | Some clean-ups for XLogReadDetermineTimeline() & read_local_xlog_page_guts() |
| Previous Message | Heikki Linnakangas | 2026-10-23 12:15:03 | Re: [PATCH v1 1/1] Add GENERATED ALWAYS AS ROW IDENTITY columns |