Re: Use atexit() in initdb and pg_basebackup

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use atexit() in initdb and pg_basebackup
Date: 2019-01-07 15:37:28
Message-ID: d024a32c-96ac-e7c1-cc7b-024e4085f997@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05/01/2019 16:42, Alvaro Herrera wrote:
>> Yeah. Actually, we already have a solution of this in pg_basebackup,
>> with a bool success variable. I rewrote it like that. At least it's
>> better for uniformity.
>
> Ah, yeah, much better, LGTM.
>
>> I also added an atexit() conversion in isolationtester. It's mostly the
>> same thing.
>
> LGTM in a quick eyeball.

committed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2019-01-07 16:12:45 Re: Using logical replication with older version subscribers
Previous Message Alvaro Herrera 2019-01-07 14:54:03 Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name