Re: Make ON_ERROR_STOP stop on shell script failure

From: David Zhang <david(dot)zhang(at)highgo(dot)ca>
To: bt22nakamorit <bt22nakamorit(at)oss(dot)nttdata(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Make ON_ERROR_STOP stop on shell script failure
Date: 2022-12-14 00:40:02
Message-ID: ce98bad5-cd4d-55d2-8916-052e557cce9b@highgo.ca
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-10-12 2:13 a.m., bt22nakamorit wrote:
> There was a mistake in the error message for \! so I updated the patch.
>
Tried to apply this patch to the master branch, but got the error like
below.
$ git apply --check patch-view.diff
error: patch failed: src/bin/psql/command.c:2693
error: src/bin/psql/command.c: patch does not apply

I think there are some tests related with "ON_ERROR_STOP" in
src/bin/psql/t/001_basic.pl, and we should consider to add corresponding
test cases for "on/off/shell/all" to this patch.

Best regards,

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2022-12-14 00:41:05 Re: wake up logical workers after ALTER SUBSCRIPTION
Previous Message Tom Lane 2022-12-14 00:20:14 Re: wake up logical workers after ALTER SUBSCRIPTION