Re: pause recovery if pitr target not reached

From: "Leif Gunnar Erlandsen" <leif(at)lako(dot)no>
To: "Peter Eisentraut" <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz>
Cc: "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pause recovery if pitr target not reached
Date: 2020-01-15 08:25:17
Message-ID: cd8f99b383efe0dedc462e7fd6446865@lako.no
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> "Peter Eisentraut" <peter(dot)eisentraut(at)2ndquadrant(dot)com> skrev 14. januar 2020 kl. 21:13:
>
> On 2019-12-11 12:40, Leif Gunnar Erlandsen wrote:
>> Adding patch written for 13dev from git
>> "Michael Paquier" <michael(at)paquier(dot)xyz> skrev 1. desember 2019 kl. 03:08:
>> On Fri, Nov 22, 2019 at 11:26:59AM +0000, Leif Gunnar Erlandsen wrote:
>
>> No it does not. It works well to demonstrate its purpose though.
>> And it might be to stop with FATAL would be more correct.
>
> This is still under active discussion. Please note that the latest
> patch does not apply, so a rebase would be nice to have. I have moved
> the patch to next CF, waiting on author.
>
> I reworked your patch a bit. I changed the outcome to be an error, as was discussed. I also added
> tests and documentation. Please take a look.

Thank you, it was not unexpexted for the patch to be a little bit smaller.
Although it would have been nice to log where recover ended before reporting fatal error.
And since you use RECOVERY_TARGET_UNSET, RECOVERY_TARGET_IMMEDIATE also gets included, is this correct?

> -- Peter Eisentraut http://www.2ndQuadrant.com
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2020-01-15 10:04:41 Re: proposal: type info support functions for functions that use "any" type
Previous Message Kyotaro Horiguchi 2020-01-15 08:18:57 Re: [HACKERS] WAL logging problem in 9.4.3?