Re: list of extended statistics on psql

From: Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: list of extended statistics on psql
Date: 2020-11-10 08:12:19
Message-ID: cba60869-358d-dfc5-7e01-92bd703414fd@nttcom.co.jp_1
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,


>> 2) The test is failing intermittently because it's executed in parallel
>> with stats_ext test, which is also creating extended statistics. So
>> depending on the timing the \dX may list some of the stats_ext stuff.
>> I'm not sure what to do about this. Either this part needs to be moved
>> to a separate test executed in a different group, or maybe we should
>> simply move it to stats_ext.
>
> I thought all tests related to meta-commands exist in psql.sql, but I
> realize it's not true. For example, the test of \dRp does not exist in
> psql.sql. Therefore, I moved the regression test of \dX to stats_ext.sql
> to avoid the test failed in parallel.
>
> Attached patches is following:
>  - 0001-v8-Add-dX-command-on-psql.patch
>  - 0002-Add-regression-test-of-dX-to-stats_ext.sql.patch
>
> However, I feel the test of \dX is not elegant, so I'm going to try
> creating another one since it would be better to be aware of the context
> of existing extended stats tests.

I tried to create another version of the regression test (0003).
"\dX" was added after ANALYZE command or SELECT... from pg_statistic_ext.

Please find the attached file:
- 0003-Add-regression-test-of-dX-to-stats_ext.sql-another-ver

Both regression tests 0002 and 0003 are okay for me, I think.
Could you choose one?

Regards,
Tatsuro Yamada

Attachment Content-Type Size
0003-Add-regression-test-of-dX-to-stats_ext.sql-another-ver.patch text/plain 7.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-11-10 08:29:22 Re: enable pg_stat_statements to track rows processed by REFRESH MATERIALIZED VIEW
Previous Message Kyotaro Horiguchi 2020-11-10 07:17:40 Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module