Re: [HACKERS] Database owner installable modules patch

From: "Tom Dunstan" <pgsql(at)tomd(dot)cc>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Gregory Stark" <stark(at)enterprisedb(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Database owner installable modules patch
Date: 2008-04-07 14:39:08
Message-ID: ca33c0a30804070739m753dd2cp1026cc0cd4742fc0@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Mon, Apr 7, 2008 at 7:55 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Tom Dunstan" <pgsql(at)tomd(dot)cc> writes:
> > OK, I found an example that does NOT fit the "just drop all
> > dependencies" scenario, but that I would still like to support. I just
> > had a look at the postgis pl/java support, and its install does stuff
> > like "SELECT sqlj.install_jar('file://${PWD}/postgis_pljava.jar',
> > 'postgis_pljava_jar', false);" and "SELECT
> > sqlj.add_type_mapping('geometry', 'org.postgis.pljava.PLJGeometry');".
> > There's no way we can deal with that sort of thing automatically, so
> > we'll have to support uninstall scripts regardless.
>
> Well, that just begs the question of what those commands actually *do*.
> It seems not unlikely that they'd be inserting data into tables that
> would belong to the module, in which case an uninstall that dropped
> the table would be fine.

Those tables belong to a *different* module, though. I'm picturing
three modules here: pljava, postgis, and a postgis-pljava support
module that requires the first two, since it should be possible to
install postgis without requiring pljava. The above stuff was from the
install script of the postgis-pljava code, but inserted data into
tables owned by pljava.

Cheers

Tom

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2008-04-07 14:41:13 Re: problem with locks on head, backend crash
Previous Message Pavel Stehule 2008-04-07 14:36:37 problem with locks on head, backend crash

Browse pgsql-patches by date

  From Date Subject
Next Message Decibel! 2008-04-07 18:26:52 Re: TRUNCATE TABLE with IDENTITY
Previous Message Heikki Linnakangas 2008-04-07 14:30:29 Re: Improve shutdown during online backup