Re: Allow tests to pass in OpenSSL FIPS mode

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Allow tests to pass in OpenSSL FIPS mode
Date: 2023-10-05 13:44:19
Message-ID: c8f11f3c-c267-1f62-f90c-619b8fae9013@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04.10.22 17:45, Peter Eisentraut wrote:
> While working on the column encryption patch, I wanted to check that
> what is implemented also works in OpenSSL FIPS mode.  I tried running
> the normal test suites after switching the OpenSSL installation to FIPS
> mode, but that failed all over the place.  So I embarked on fixing that.
>  Attached is a first iteration of a patch.

Continuing this, we have fixed many issues since. Here is a patch set
to fix all remaining issues.

v4-0001-citext-Allow-tests-to-pass-in-OpenSSL-FIPS-mode.patch
v4-0002-pgcrypto-Allow-tests-to-pass-in-OpenSSL-FIPS-mode.patch

These two are pretty straightforward.

v4-0003-Allow-tests-to-pass-in-OpenSSL-FIPS-mode-TAP-test.patch

This one does some delicate surgery and could use some thorough review.

v4-0004-Allow-tests-to-pass-in-OpenSSL-FIPS-mode-rest.patch

This just adds alternative expected files. The question is mainly just
whether there are better ways to organize this.

v4-0005-WIP-Use-fipshash-in-brin_multi-test.patch

Here, some previously fixed md5() uses have snuck back in. I will need
to track down the origin of this and ask for a proper fix there. This
is just included here for completeness.

Attachment Content-Type Size
v4-0001-citext-Allow-tests-to-pass-in-OpenSSL-FIPS-mode.patch text/plain 2.3 KB
v4-0002-pgcrypto-Allow-tests-to-pass-in-OpenSSL-FIPS-mode.patch text/plain 9.9 KB
v4-0003-Allow-tests-to-pass-in-OpenSSL-FIPS-mode-TAP-test.patch text/plain 12.9 KB
v4-0004-Allow-tests-to-pass-in-OpenSSL-FIPS-mode-rest.patch text/plain 16.6 KB
v4-0005-WIP-Use-fipshash-in-brin_multi-test.patch text/plain 5.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-10-05 13:53:16 Re: Good News Everyone! + feature proposal
Previous Message Jean-Christophe Arnu 2023-10-05 13:36:55 Re: FDW pushdown of non-collated functions