Re: New GUC to sample log queries

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>
Cc: Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info>, Michael Paquier <michael(at)paquier(dot)xyz>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New GUC to sample log queries
Date: 2018-07-16 21:06:44
Message-ID: c87ef099-5f65-7e9a-d0f3-f5d850d19689@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 07/16/2018 05:24 PM, Robert Haas wrote:
> On Sun, Jul 15, 2018 at 6:53 AM, Vik Fearing
> <vik(dot)fearing(at)2ndquadrant(dot)com> wrote:
>> Hmm. Not sure if that last word should be _sample, _sampling, _rate, or
>> a combination of those.
>
> +1 for rate or sample_rate. I think "sample" or "sampling" without
> "rate" will not be very clear.
>

1+ to sample_rate

It's what auto_explain and pgbench uses, so let's keep the naming
consistent.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-07-16 21:59:43 Re: AtEOXact_ApplyLauncher() and subtransactions
Previous Message Tomas Vondra 2018-07-16 20:55:37 Re: [HACKERS] PATCH: multivariate histograms and MCV lists