| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | pg(at)bowt(dot)ie, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, bhushan(dot)uparkar(at)gmail(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Subject: | Re: Index Skip Scan |
| Date: | 2018-09-11 13:21:57 |
| Message-ID: | c87d41ae-7c18-a3a1-96f2-f366a43412dc@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Dmitry,
On 9/10/18 5:47 PM, Dmitry Dolgov wrote:
>> On Mon, 18 Jun 2018 at 17:26, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> wrote:
> I've looked through the patch more closely, and have a few questions:
>
Thanks for your review !
> * Is there any reason why only copy function for the IndexOnlyScan node
> includes an implementation for distinctPrefix?
Oversight -- thanks for catching that.
> * What is the purpose of HeapFetches? I don't see any usage of this variable
> except assigning 0 to it once.
>
That can be removed.
New version WIP v2 attached.
Best regards,
Jesper
| Attachment | Content-Type | Size |
|---|---|---|
| wip_indexskipscan_v2.patch | text/x-patch | 31.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marina Polyakova | 2018-09-11 13:47:57 | Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors |
| Previous Message | Higuchi, Daisuke | 2018-09-11 10:36:51 | RE: stat() on Windows might cause error if target file is larger than 4GB |