Re: authtype parameter in libpq

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: authtype parameter in libpq
Date: 2021-03-09 14:51:41
Message-ID: c5c49d2c-11cf-9717-36f3-76282e85f5b0@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08.03.21 10:57, Peter Eisentraut wrote:
> On 04.03.21 16:06, Daniel Gustafsson wrote:
>> authtype is completely dead in terms of reading back the value, to the
>> point of
>> it being a memleak if it indeed was found in as an environment variable.
>>
>>> But I tend to think we should remove them both altogether (modulo ABI
>>> and API preservation).
>>
>> No disagreement from me, the attached takes a stab at that to get an
>> idea what
>> it would look like.  PQtty is left to maintain API stability but the
>> parameters
>> are removed from the conn object as thats internal to libpq.
>
> This looks like this right idea to me.

committed, with some tweaks

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rahila Syed 2021-03-09 15:05:21 Re: row filtering for logical replication
Previous Message David Steele 2021-03-09 14:47:28 Re: default result formats setting