On 25.03.22 14:08, Peter Eisentraut wrote:
>> 2. Some of these comment lines have become pretty long after having
>> added the attribute macro.
>>
>> e.g.
>>
>> PlannerInfo *subroot pg_node_attr(readwrite_ignore); /* modified
>> "root" for planning the subquery;
>> not printed, too large, not interesting enough */
>>
>> I wonder if you'd be better to add a blank line above, then put the
>> comment on its own line, i.e:
>>
>> /* modified "root" for planning the subquery; not printed, too large,
>> not interesting enough */
>> PlannerInfo *subroot pg_node_attr(readwrite_ignore);
>
> Yes, my idea was to make a separate patch first that reformats many of
> the structs and comments in that way.
Here is a patch that reformats the relevant (and a few more) comments
that way. This has been run through pgindent, so the formatting should
be stable.