Add information to rm_redo_error_callback()

From: "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Subject: Add information to rm_redo_error_callback()
Date: 2020-08-04 15:37:05
Message-ID: c31e2cba-efda-762c-f4ad-5c25e5dac3d0@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

I've attached a small patch to add information to rm_redo_error_callback().

The changes attached in this patch came while working on the "Add
information during standby recovery conflicts" patch (See [1]).

The goal is to add more information during the callback (if doable), so
that something like:

2020-08-04 14:42:57.545 UTC [15459] CONTEXT:  WAL redo at 0/4A3B0DE0 for
Heap2/CLEAN: remxid 1168

would get extra information that way:

2020-08-04 14:42:57.545 UTC [15459] CONTEXT:  WAL redo at 0/4A3B0DE0 for
Heap2/CLEAN: remxid 1168, blkref #0: rel 1663/13586/16850 fork main blk 0

As this could be useful outside of [1], a dedicated "sub" patch has been
created (thanks Sawada for the suggestion).

I will add this patch to the next commitfest. I look forward to your
feedback about the idea and/or implementation.

Regards,

Bertrand

[1]: https://commitfest.postgresql.org/29/2604

Attachment Content-Type Size
v1-0001-improve-rm_redo_error_callback.patch text/plain 1022 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2020-08-04 16:00:23 Re: new heapcheck contrib module
Previous Message Alexander Korotkov 2020-08-04 15:24:39 Re: LSM tree for Postgres