Re: split up psql \d Modifiers column

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: split up psql \d Modifiers column
Date: 2016-11-03 18:08:24
Message-ID: c27d40f8-8c0e-380b-66bc-2461b25e99ac@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/2/16 12:24 PM, Kuntal Ghosh wrote:
> On Fri, Oct 28, 2016 at 9:00 AM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> I propose to change the psql \d output a bit, best shown with an example:
>>
>> \d persons3
>> - Table "public.persons3"
>> - Column | Type | Modifiers
>> ---------+---------+------------------
>> - id | integer | not null
>> - name | text | default ''::text
>> + Table "public.persons3"
>> + Column | Type | Collation | Nullable | Default
>> +--------+---------+-----------+----------+----------
>> + id | integer | | not null |
>> + name | text | | | ''::text
>>
> +1.
> psql-ref.sgml(line 4085) needs to be modified. Otherwise, the patch
> looks good to me.

Good catch. I didn't see that because it said "Modifier" instead of
"Modifiers". I also saw that the domain listing \dD also used
"Modifier", so I updated that as well to the new style. I have
committed the patch. Thanks for reviewing it.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kuntal Ghosh 2016-11-03 19:16:36 Re: WAL consistency check facility
Previous Message Jesper Pedersen 2016-11-03 18:00:33 Re: Microvacuum support for Hash Index