Re: Logical replication existing data copy

On 23/02/17 01:41, Petr Jelinek wrote:
> On 23/02/17 01:02, Erik Rijkers wrote:
>> On 2017-02-22 18:13, Erik Rijkers wrote:
>>> On 2017-02-22 14:48, Erik Rijkers wrote:
>>>> On 2017-02-22 13:03, Petr Jelinek wrote:
>>>>
>>>>> 0001-Skip-unnecessary-snapshot-builds.patch
>>>>> 0002-Don-t-use-on-disk-snapshots-for-snapshot-export-in-l.patch
>>>>> 0003-Fix-xl_running_xacts-usage-in-snapshot-builder.patch
>>>>> 0001-Use-asynchronous-connect-API-in-libpqwalreceiver.patch
>>>>> 0002-Fix-after-trigger-execution-in-logical-replication.patch
>>>>> 0003-Add-RENAME-support-for-PUBLICATIONs-and-SUBSCRIPTION.patch
>>>>> 0001-Logical-replication-support-for-initial-data-copy-v5.patch
>>>>
>>>> It works well now, or at least my particular test case seems now solved.
>>>
>>> Cried victory too early, I'm afraid.
>>>
>>
>> I got into a 'hung' state while repeating pgbench_derail2.sh.
>>
>> Below is some state. I notice that master pg_stat_replication.syaye is
>> 'startup'.
>> Maybe I should only start the test after that state has changed. Any of the
>> other possible values (catchup, streaming) wuold be OK, I would think.
>>
>
> I think that's known issue (see comment in tablesync.c about hanging
> forever). I think I may have fixed it locally.
>
> I will submit patch once I fixed the other snapshot issue (I managed to
> reproduce it as well, although very rarely so it's rather hard to test).
>

Hi,

Here it is. But check also the snapbuild related thread for updated
patches related to that (the issue you had with this not copying all
rows is yet another pre-existing Postgres bug).

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services