Re: [HACKERS] PATCH: multivariate histograms and MCV lists

On 11/26/18 11:29 PM, Thomas Munro wrote:
> On Mon, Sep 3, 2018 at 11:17 AM Tomas Vondra
> <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>> Attached is an updated version of the patch series, adopting a couple of
>> improvements - both for MCV lists and histograms.
>
> Hello Tomas,
>
> FYI, here are a couple of warnings from GCC (I just noticed because I
> turned on -Werror on cfbot so your patch turned red):
>
> extended_stats.c: In function ‘statext_clauselist_selectivity’:
> extended_stats.c:1227:6: error: ‘other_sel’ may be used uninitialized
> in this function [-Werror=maybe-uninitialized]
> sel = mcv_sel + other_sel;
> ^
> extended_stats.c:1091:5: note: ‘other_sel’ was declared here
> other_sel,
> ^
> extended_stats.c:1227:6: error: ‘mcv_sel’ may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
> sel = mcv_sel + other_sel;
> ^
> extended_stats.c:1087:5: note: ‘mcv_sel’ was declared here
> mcv_sel,
> ^
>

Thanks, I'll fix that in the next version of the patch I'm working on.

cheers

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services