| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql - factor out echo code |
| Date: | 2023-02-13 10:41:02 |
| Message-ID: | c02d0269-9bf4-0411-82e7-f837fa38cd90@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01.12.22 08:27, Pavel Stehule wrote:
> st 30. 11. 2022 v 10:43 odesílatel Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr
> <mailto:coelho(at)cri(dot)ensmp(dot)fr>> napsal:
>
>
> >> Now some of the output generated by test_extdepend gets a bit
> >> confusing:
> >> +-- QUERY:
> >> +
> >> +
> >> +-- QUERY:
> >>
> >> That's not entirely this patch's fault. Still that's not really
> >> intuitive to see the output of a query that's just a blank spot..
> >
> > Hmmm.
> >
> > What about adding an explicit \echo before these empty outputs to
> mitigate
> > the possible induced confusion?
>
> \echo is not possible.
>
> Attached an attempt to improve the situation by replacing empty
> lines with
> comments in this test.
>
>
> I can confirm so all regress tests passed
I think this patch requires an up-to-date summary and explanation. The
thread is over a year old and the patch has evolved quite a bit. There
are some test changes that are not explained. Please provide more
detail so that the patch can be considered.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-02-13 10:58:02 | Re: Helper functions for wait_for_catchup() in Cluster.pm |
| Previous Message | Peter Eisentraut | 2023-02-13 10:35:14 | Re: Rework of collation code, extensibility |