Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

From: Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Jose Luis Tallon <jltallon(at)adv-solutions(dot)net>
Subject: Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly
Date: 2020-11-30 14:12:42
Message-ID: bfc3903c0e30ef4349ec5cfee625d8d5@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-11-30 14:33, Michael Paquier wrote:
> On Tue, Nov 24, 2020 at 09:31:23AM -0600, Justin Pryzby wrote:
>> @cfbot: rebased
>
> Catching up with the activity here, I can see four different things in
> the patch set attached:
> 1) Refactoring of the grammar of CLUSTER, VACUUM, ANALYZE and REINDEX
> to support values in parameters.
> 2) Tablespace change for REINDEX.
> 3) Tablespace change for VACUUM FULL/CLUSTER.
> 4) Tablespace change for indexes with VACUUM FULL/CLUSTER.
>
> I am not sure yet about the last three points, so let's begin with 1)
> that is dealt with in 0001 and 0002. I have spent some time on 0001,
> renaming the rule names to be less generic than "common", and applied
> it. 0002 looks to be in rather good shape, still there are a few
> things that have caught my eyes. I'll look at that more closely
> tomorrow.
>

Thanks. I have rebased the remaining patches on top of 873ea9ee to use
'utility_option_list' instead of 'common_option_list'.

Regards
--
Alexey Kondratov

Postgres Professional https://www.postgrespro.com
Russian Postgres Company

Attachment Content-Type Size
v31-0005-Implement-vacuum-full-cluster-INDEX_TABLESPACE-t.patch text/x-diff 18.9 KB
v31-0004-Allow-CLUSTER-and-VACUUM-FULL-to-change-tablespa.patch text/x-diff 23.4 KB
v31-0003-Refactor-and-reuse-set_rel_tablespace.patch text/x-diff 6.6 KB
v31-0002-Allow-REINDEX-to-change-tablespace.patch text/x-diff 36.7 KB
v31-0001-Change-REINDEX-CLUSTER-to-accept-an-option-list.patch text/x-diff 19.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2020-11-30 14:27:12 Re: Online verification of checksums
Previous Message Li Japin 2020-11-30 14:08:44 Re: Printing LSN made easy