Re: [PATCH] psql: add tab completion for \df slash command suffixes

From: Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>
To: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] psql: add tab completion for \df slash command suffixes
Date: 2019-09-04 06:19:57
Message-ID: bf93f787-c98e-19cc-009c-147d8d5165b8@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019/09/04 15:14, Kuntal Ghosh wrote:
> Hello Ian,
>
> On Fri, Aug 30, 2019 at 10:31 AM Ian Barwick
> <ian(dot)barwick(at)2ndquadrant(dot)com> wrote:
>> I just noticed "\df[TAB]" fails to offer any tab-completion for
>> the possible suffixes ("\dfa", "\dfn", "\dfp", "\dft" and "\dfw").
>> Trivial patch attached, which applies back to Pg96, and separate
>> patches for Pg95 and Pg94.
>>
>> I'll add this to the next commitfest.
> I've reviewed the patch. It works as expected in master. But, the
> syntax "\dfp" doesn't exist beyond Pg11. So, you've to remove the same
> from the patches for Pg95 and Pg94. I guess the same patch should be
> applied on Pg10 and Pg96.

Ah, good catch, I will update and resubmit.

Thanks!

Ian Barwick

--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-09-04 06:47:16 Re: [Patch] Mingw: Fix import library extension, build actual static libraries
Previous Message Thomas Munro 2019-09-04 06:18:31 Append with naive multiplexing of FDWs