Re: [BUG] Logical replica crash if there was an error in a function.

From: "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Maxim Orlov <orlovmg(at)gmail(dot)com>
Subject: Re: [BUG] Logical replica crash if there was an error in a function.
Date: 2023-04-06 10:24:21
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 05.04.2023 17:35, Tom Lane wrote:
> "Anton A. Melnikov" <aamelnikov(at)inbox(dot)ru> writes:
>> On 03.04.2023 21:49, Tom Lane wrote:
>>> I did not think this case was worth memorializing in a test before,
>>> and I still do not. I'm inclined to reject this patch.
>> Could you help me to figure out, please.
> The problem was an Assert that was speculative when it went in,
> and which we eventually found was wrong in the context of logical
> replication. We removed the Assert. I don't think we need a test
> case to keep us from putting back the Assert. That line of thinking
> leads to test suites that run for fourteen hours and are near useless
> because developers can't run them easily.
> regards, tom lane

Ok, i understand! Thanks a lot for the clarification. A rather important point,
i'll take it into account for the future.
Let's do that. Revoked the patch.

With the best wishes!

Anton A. Melnikov
Postgres Professional:
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2023-04-06 11:34:44 Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode
Previous Message Amit Kapila 2023-04-06 09:55:18 Re: Minimal logical decoding on standbys