| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pageinspect: Hash index support |
| Date: | 2016-09-20 18:25:19 |
| Message-ID: | bee4df6a-79d2-f04e-7f2c-c31581c25a45@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09/20/2016 12:45 PM, Jeff Janes wrote:
> Is the 2nd "1" in this call needed?
>
> SELECT * FROM hash_page_stats(get_raw_page('mytab_index', 1), 1)
>
> As far as I can tell, that argument is only used to stuff into the output
> field "blkno", it is not used to instruct the interpretation of the raw
> page itself. It doesn't seem worthwhile to have the parameter that only
> echos back to the user what the user already put in (twice). The only
> existing funtions which take the blkno argument are those that don't use
> the get_raw_page style.
>
> Also, should we document what the single letter values mean in the
> hash_page_stats.type column? It is not obvious that 'i' means bitmap, for
> example.
>
Adjusted in v4. Code/doc will need an update once the CHI patch goes in.
Best regards,
Jesper
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pageinspect-Hash-index-support_v4.patch | text/x-patch | 32.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-09-20 18:26:29 | Re: "Some tests to cover hash_index" |
| Previous Message | Alvaro Herrera | 2016-09-20 18:09:04 | Re: [PATCH] get_home_path: use HOME |