| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactor parse analysis of EXECUTE command |
| Date: | 2019-11-29 10:39:31 |
| Message-ID: | bd4f429b-e7bd-93f4-a4b8-4368c5afa8a3@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
After digesting the discussion, let's reshuffle this a bit.
I have committed the change that adds the error location in one place.
That worked independently.
Attached is a new patch that refactors things a bit to pass the
ParseState into functions such as PrepareQuery() and ExecuteQuery()
instead of passing the query string and query environment as a separate
arguments. We had already done that for most utility commands; there
were just some left that happened to be involved in the current thread's
discussion anyway.
That's a nice cosmetic improvement in any case, but I think that it
would also help with the issue of passing parameters into some utility
commands later on. I will look into that some other time.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Make-better-use-of-ParseState-in-ProcessUtility.patch | text/plain | 14.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2019-11-29 11:12:26 | Re: dropdb --force |
| Previous Message | Daniel Gustafsson | 2019-11-29 10:10:32 | Re: Update minimum SSL version |